From e4971201dd34f4ff584715f0b8fe1a32b8829189 Mon Sep 17 00:00:00 2001
From: Reto Lehmann <retocode@icloud.com>
Date: Mon, 9 Oct 2023 15:39:38 +0200
Subject: [PATCH] Minor fixes

---
 DEVELOPMENT.md                         | 4 ++--
 pkg/reconciler/ingress/ingress.go      | 2 +-
 pkg/reconciler/ingress/ingress_test.go | 8 ++++----
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/DEVELOPMENT.md b/DEVELOPMENT.md
index 1e84f0b6e2..ba0a4183ee 100644
--- a/DEVELOPMENT.md
+++ b/DEVELOPMENT.md
@@ -82,8 +82,8 @@ istioctl install -y
 Run the following command to install Knative
 
 ```shell
-kubectl apply --filename https://storage.googleapis.com/knative-nightly/serving/latest/serving-crds.yaml
-kubectl apply --filename https://storage.googleapis.com/knative-nightly/serving/latest/serving-core.yaml
+kubectl apply -f https://github.com/knative/serving/releases/latest/download/serving-crds.yaml
+kubectl apply -f https://github.com/knative/serving/releases/latest/download/serving-core.yaml
 ```
 
 ### Install Knative net-istio
diff --git a/pkg/reconciler/ingress/ingress.go b/pkg/reconciler/ingress/ingress.go
index c035764c42..129c054c5b 100644
--- a/pkg/reconciler/ingress/ingress.go
+++ b/pkg/reconciler/ingress/ingress.go
@@ -358,7 +358,7 @@ func (r *Reconciler) reconcileVirtualServices(ctx context.Context, ing *v1alpha1
 }
 
 func (r *Reconciler) reconcileDestinationRules(ctx context.Context, ing *v1alpha1.Ingress) error {
-	var drs = sets.String{}
+	var drs = sets.New[string]()
 	for _, rule := range ing.Spec.Rules {
 		for _, path := range rule.HTTP.Paths {
 			// Currently DomainMappings point to the cluster local domain on the local gateway.
diff --git a/pkg/reconciler/ingress/ingress_test.go b/pkg/reconciler/ingress/ingress_test.go
index 2a7412c9c0..32e262767b 100644
--- a/pkg/reconciler/ingress/ingress_test.go
+++ b/pkg/reconciler/ingress/ingress_test.go
@@ -707,7 +707,7 @@ func TestReconcile_EnableSystemInternalTLS(t *testing.T) {
 	}))
 }
 
-func TestReconcile_EnableAutoTLS(t *testing.T) {
+func TestReconcile_ExternalDomainTLS(t *testing.T) {
 	table := TableTest{{
 		Name:                    "create Ingress Gateway to match newly created Ingress",
 		SkipNamespaceValidation: true,
@@ -1252,8 +1252,8 @@ func TestReconcile_EnableAutoTLS(t *testing.T) {
 							}},
 						},
 						Network: &netconfig.Config{
-							HTTPProtocol: netconfig.HTTPDisabled,
-							AutoTLS:      true,
+							HTTPProtocol:      netconfig.HTTPDisabled,
+							ExternalDomainTLS: true,
 						},
 					},
 				},
@@ -1406,7 +1406,7 @@ func ReconcilerTestConfig() *config.Config {
 			}},
 		},
 		Network: &netconfig.Config{
-			AutoTLS: false,
+			ExternalDomainTLS: false,
 		},
 	}
 }