chore: Migrate to sets.Set[string] when possible

[pastequo]

Changes

• 🧹 Migrate sets.String to sets.Set[string] when possible, sets.String being deprecated
• Not every place could have been changed, some dependencies (internal to knative, external to this repo) are still using sets.String

/kind cleanup

This chnages is motivated by the linter complaining about that

[knative-prow]

Hi @pastequo. Thanks for your PR.

I'm waiting for a knative-sandbox member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dprotaso]

/ok-to-test

[codecov]

Codecov Report

Merging #1142 (31714c3) into main (acf343f) will increase coverage by 0.12%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1142      +/-   ##
==========================================
+ Coverage   81.29%   81.42%   +0.12%     
==========================================
  Files          18       18              
  Lines        1588     1599      +11     
==========================================
+ Hits         1291     1302      +11     
  Misses        213      213              
  Partials       84       84              

Files Changed	Coverage Δ
pkg/reconciler/ingress/ingress.go	69.49% <100.00%> (ø)
pkg/reconciler/ingress/lister.go	97.50% <100.00%> (+0.10%)	⬆️
pkg/reconciler/ingress/resources/gateway.go	86.13% <100.00%> (ø)
...kg/reconciler/ingress/resources/virtual_service.go	94.71% <100.00%> (+0.14%)	⬆️

[dprotaso]

thanks @pastequo just some minor linter stuff - see the 'Files Changed' tab

[pastequo]

Sure, I couldn't remove this one, so I put a // nolint: staticcheck instead

edit: there is another remaining sets.String that couldn't been removed as well. The linter doesn't seem to complain (yet)

[kauana]

/lgtm

[dprotaso]

/approve

thanks @pastequo and @kauana for the review

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, pastequo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment