Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate to sets.Set[string] when possible #1142

Merged

chore: Remove unused test methods, add nolint for remaining sets.String

31714c3
Select commit
Loading
Failed to load commit list.
Merged

chore: Migrate to sets.Set[string] when possible #1142

chore: Remove unused test methods, add nolint for remaining sets.String
31714c3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 28, 2023 in 1s

81.42% (target 80.00%)

View this Pull Request on Codecov

81.42% (target 80.00%)

Details

Codecov Report

Merging #1142 (31714c3) into main (acf343f) will increase coverage by 0.12%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1142      +/-   ##
==========================================
+ Coverage   81.29%   81.42%   +0.12%     
==========================================
  Files          18       18              
  Lines        1588     1599      +11     
==========================================
+ Hits         1291     1302      +11     
  Misses        213      213              
  Partials       84       84              
Files Changed Coverage Δ
pkg/reconciler/ingress/ingress.go 69.49% <100.00%> (ø)
pkg/reconciler/ingress/lister.go 97.50% <100.00%> (+0.10%) ⬆️
pkg/reconciler/ingress/resources/gateway.go 86.13% <100.00%> (ø)
...kg/reconciler/ingress/resources/virtual_service.go 94.71% <100.00%> (+0.14%) ⬆️