-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Return LB status for each gateway #1218
Conversation
Hi @pastequo. Thanks for your PR. I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pastequo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
return fmt.Errorf("failed to get external LB status: %w", err) | ||
} | ||
|
||
privateLbs, err := getLBStatuses(ctx, v1alpha1.IngressVisibilityClusterLocal) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my understanding, this will set multiple gateways to the LB status when users configured multiple gateways. Did that work with serving? For example, here is the code which disallows it -
https://github.com/knative/serving/blob/9b0d1851055e91ced3965dc3cb8d9edb08f833ee/pkg/reconciler/route/resources/service.go#L87-L91
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I wasn't aware of such limitation at serving side.
Small remark tho, we can have multiple istio gateways that point to the same istio ingress gateway (and therefore LB)
Changes
/kind bug
Fixes #718
Note that the issue rather recommend to avoid setting multiple gateway in the config.
Release Note
Docs