Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ko label filter instead of removing KnativeCertificate yaml #1224

Merged
merged 1 commit into from
Dec 7, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/700-istio-knative-certificate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ metadata:
networking.knative.dev/certificate.class: cert-manager.certificate.networking.knative.dev
labels:
networking.knative.dev/certificate-type: system-internal
knative.dev/install-knative-certificate: "true"
name: routing-serving-certs
namespace: istio-system
spec:
Expand Down
6 changes: 2 additions & 4 deletions test/e2e-common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,9 @@ function test_setup() {

${istio_dir}/install-istio.sh ${istio_profile} || return 1

# Remove Knative Certificate as we are running without Serving CRs
rm -f config/700-istio-knative-certificate.yaml

echo ">> Bringing up net-istio Ingress Controller"
ko apply --platform=linux/amd64 -f config/ || return 1
# Do not install Knative Certificate for e2e tests, as we are running without Serving CRs
ko apply --platform=linux/amd64 -l knative.dev/install-knative-certificate!=true -f config/ || return 1

if [[ -f "${istio_dir}/${istio_profile}/config-istio.yaml" ]]; then
kubectl apply -f "${istio_dir}/${istio_profile}/config-istio.yaml"
Expand Down
Loading