Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.12] bump istio v1.19.6 #1239

Merged

Conversation

dprotaso
Copy link
Contributor

No description provided.

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 15, 2024
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (230378a) 81.66% compared to head (72c5885) 81.66%.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.12    #1239   +/-   ##
=============================================
  Coverage         81.66%   81.66%           
=============================================
  Files                19       19           
  Lines              1680     1680           
=============================================
  Hits               1372     1372           
  Misses              220      220           
  Partials             88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ReToCode
Copy link
Member

Hm there are conflicts on prow builds?

@dprotaso
Copy link
Contributor Author

It's a weird prow bug - the branch was opened against main by accident so you see the main jobs - latest_net-istio_main

Changing the base target to release-1.11 made the release branch jobs show up latest_net-istio_release-1.12 but it doesn't remove the main jobs

Since everything passed tide is just looking for an lgtm - Not mergeable. Needs lgtm label.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2024
Copy link

knative-prow bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, gabo1208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andrew-su
Copy link
Contributor

/retest

@dprotaso
Copy link
Contributor Author

/override "build-tests_net-istio_main"

Copy link

knative-prow bot commented Jan 15, 2024

@dprotaso: Overrode contexts on behalf of dprotaso: build-tests_net-istio_main

In response to this:

/override "build-tests_net-istio_main"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Contributor Author

/override integration-tests_net-istio_main
/override latest-mesh_net-istio_main
/override latest_net-istio_main
/override unit-tests_net-istio_main

Copy link

knative-prow bot commented Jan 15, 2024

@dprotaso: Overrode contexts on behalf of dprotaso: integration-tests_net-istio_main, latest-mesh_net-istio_main, latest_net-istio_main, unit-tests_net-istio_main

In response to this:

/override integration-tests_net-istio_main
/override latest-mesh_net-istio_main
/override latest_net-istio_main
/override unit-tests_net-istio_main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit 2b8acf2 into knative-extensions:release-1.12 Jan 15, 2024
85 checks passed
@dprotaso dprotaso deleted the release-112-bump-istio branch January 15, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants