Use istio.sidecar.inject label instead of annotation

[ReToCode]

Partially knative/serving#15521

Proposed Changes

• Use istio.sidecar.inject label instead of annotation

/assign @skonto

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.19%. Comparing base (a9517c7) to head (afc0086).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1369   +/-   ##
=======================================
  Coverage   82.19%   82.19%           
=======================================
  Files          25       25           
  Lines        1601     1601           
=======================================
  Hits         1316     1316           
  Misses        189      189           
  Partials       96       96           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[skonto]

It seems Istio specifies both https://github.com/knative-extensions/net-istio/blob/main/third_party/istio-latest/istio-ci-no-mesh/istio.yaml#L14297. Should we keep it that why? 🤔 Are there any Istio versions that this makes a difference?

[dprotaso]

It seems Istio specifies both https://github.com/knative-extensions/net-istio/blob/main/third_party/istio-latest/istio-ci-no-mesh/istio.yaml#L14297. Should we keep it that why? 🤔 Are there any Istio versions that this makes a difference?

That's a good point - which istio version added support for this in labels?

[ReToCode]

Support was added in 1.11 (https://istio.io/latest/news/releases/1.11.x/announcing-1.11/#updates-to-revision-and-tag-deployments). So I think this should be fine?

[skonto]

/lgtm
/approve

/hold for @dprotaso

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ReToCode,skonto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dprotaso]

/hold cancel