Drop rollout for e2e test which updates config-kourier #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
kind/cleanup
knative-prow
bot
added
approved
Codecov Report
@@ Coverage Diff @@
## main #1077 +/- ##
=======================================
Coverage 80.95% 80.95%
=======================================
Files 18 18
Lines 1355 1355
=======================================
Hits 1097 1097
Misses 205 205
Partials 53 53 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch drops rollout for e2e test which updates config-kourier.
Since we don't need to restart net-kourier-controller when changing
config-kourier, this patch removes therolloutcommands.The
rollout restartshould be added only for env variable change tests such as*_EXTAUTHZ_as it restarts controller and we need to wait until new pods are up./kind cleanup