-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.11] Do not use informer for startupTranslator #1109
[release-1.11] Do not use informer for startupTranslator #1109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knative-prow-robot, nak3, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9ccbee7
into
knative-extensions:release-1.11
* [release-1.11] Fix an issue where getReadyIngresses was not loading ready ingresses at startup (knative-extensions#1081) * Update getReadyIngresses to load ingresses at startup Indeed, we can't use label selector as kourier class is not a label, but an annotation. As a result, kourier does not sync ingresses at startup * Explain KUBE_API_BURST and KUBE_API_QPS --------- Co-authored-by: norbjd <norbjd@users.noreply.github.com> * Do not use informer for startupTranslator (knative-extensions#1109) Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> --------- Co-authored-by: Knative Prow Robot <automation+prow-robot@knative.team> Co-authored-by: norbjd <norbjd@users.noreply.github.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: John Doe <johndoe@localhost>
* [release-1.11] Fix an issue where getReadyIngresses was not loading ready ingresses at startup (knative-extensions#1081) * Update getReadyIngresses to load ingresses at startup Indeed, we can't use label selector as kourier class is not a label, but an annotation. As a result, kourier does not sync ingresses at startup * Explain KUBE_API_BURST and KUBE_API_QPS --------- Co-authored-by: norbjd <norbjd@users.noreply.github.com> * Do not use informer for startupTranslator (knative-extensions#1109) Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> * Leave a comment which will trigger a new dot release (knative-extensions#1134) Co-authored-by: Reto Lehmann <retocode@icloud.com> * [release-1.11] bump x/net to v0.17 (knative-extensions#1137) --------- Co-authored-by: Knative Prow Robot <automation+prow-robot@knative.team> Co-authored-by: norbjd <norbjd@users.noreply.github.com> Co-authored-by: Kenjiro Nakayama <nakayamakenjiro@gmail.com> Co-authored-by: Reto Lehmann <retocode@icloud.com> Co-authored-by: John Doe <johndoe@localhost>
This is an automated cherry-pick of #1108