Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.10][CVE-2023-44487] Update grpc to v1.56.3 #1146

Merged
merged 1 commit into from
Oct 25, 2023
Merged

[release-1.10][CVE-2023-44487] Update grpc to v1.56.3 #1146

merged 1 commit into from
Oct 25, 2023

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Oct 25, 2023

Changes

  • We should have a fixed version as we use grpc for xds and healtcheck.

@skonto skonto requested review from nak3 and ReToCode October 25, 2023 08:20
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2023
@skonto skonto changed the title [release-1.10][CVE-2023-44487] Update grpc v1.56.3 [release-1.10][CVE-2023-44487] Update grpc to v1.56.3 Oct 25, 2023
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #1146 (b4fe5b6) into release-1.10 (f0c1daa) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           release-1.10    #1146   +/-   ##
=============================================
  Coverage         80.78%   80.78%           
=============================================
  Files                18       18           
  Lines              1343     1343           
=============================================
  Hits               1085     1085           
  Misses              205      205           
  Partials             53       53

ReToCode
ReToCode approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 79c047c into knative-extensions:release-1.10 Oct 25, 2023
22 checks passed
@skonto skonto requested review from ReToCode and removed request for jsanin-vmw October 25, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nak3 nak3 Awaiting requested review from nak3

@ReToCode ReToCode Awaiting requested review from ReToCode

Assignees

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skonto @ReToCode