Skip to content

Commit

Permalink
Review improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
ReToCode committed Apr 30, 2024
1 parent ab761c3 commit 5474f29
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion docs/serving/encryption/cluster-local-domain-tls.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ status:

!!! note
A quick note on trust, all clients that call the cluster-local domain of a Knative Service need to trust the Certificate Authority
that signed the certificates. This is out of scope of Knative, but needs to be addressed to ensure a working system. Especially,
that signed the certificates. This is out of scope of Knative, but needs to be addressed to ensure a working system. Especially
when a Certificate Authority performs a rotation of the CA or the intermediate certificates. Find more information on
[Configuring Knative cert-manager integration](./configure-certmanager-integration.md#managing-trust-and-rotation-without-downtime).

8 changes: 4 additions & 4 deletions docs/serving/encryption/configure-certmanager-integration.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Configuring Knative cert-manager integration

Knative Serving relies on a bridging-component to use cert-manager for automated certificate provisioning.
Knative Serving relies on a bridging component to use cert-manager for automated certificate provisioning.
If you intend to use that feature, you need to enable the Knative cert-manager integration.

## Prerequisites
Expand All @@ -25,7 +25,7 @@ for the [three Knative Serving encryption features](./encryption-overview.md):

The following example uses a self-signed `ClusterIssuer` and the Knative cert-manager integration references that `ClusterIssuer` for all three configurations.
As this **should not be used in production** (and does not support rotating the CA without downtime),
you should think about which CA should be used for each use-case and how trust will be distributed to the clients calling the encrypted services.
you should think about which CA should be used for each use case and how trust will be distributed to the clients calling the encrypted services.
For the Knative system components, Knative provides a way to specify a bundle of CAs that should be trusted (more on this below).

There is no general answer on how to structure this, here an example on how it could look like:
Expand All @@ -49,8 +49,8 @@ In general, you can refer to the [cert-manager documentation](https://cert-manag
!!! important
Please note, that not all issuer types work for each Knative feature.

`cluster-local-domain-tls` needs to be able to sign certificates for cluster-local domains like `myapp.<namespace>`, `myapp.<namespace>.svc` and `myapp.<namespace>.svc.cluster.local`.
As the CA usually is not within the cluster, verification via ACME protocol (DNS01/HTTP01) is not possible. You can use an issuer that allows creating the these certificates (e.g. CA issuer).
`cluster-local-domain-tls` needs to be able to sign certificates for cluster-local domains like `myapp.<namespace>`, `myapp.<namespace>.svc` and `myapp.<namespace>.svc.cluster.local`.
The CA is usually outside the cluster, so verification via ACME protocol (DNS01/HTTP01) is impossible. You can use an issuer that allows the creation of these certificates (e.g., a CA issuer).

`system-internal-tls` needs to be able to sign specific SANs that Knative validates for. The defined set of SANs is:

Expand Down

0 comments on commit 5474f29

Please sign in to comment.