Skip to content

Commit

Permalink
change in doc - progress deadline annotation on per revision basis (#…
Browse files Browse the repository at this point in the history
…5777)

Co-authored-by: navinag1989 <navinag1989@gmail.com>
  • Loading branch information
knative-prow-robot and navinag1989 authored Nov 28, 2023
1 parent ac2cda4 commit 9f47cc5
Showing 1 changed file with 39 additions and 15 deletions.
54 changes: 39 additions & 15 deletions docs/serving/configuration/deployment.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,21 +73,45 @@ You may want to configure this setting as a higher value if any of the following

See the [Kubernetes documentation](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#progress-deadline-seconds) for more information.

The following example shows a snippet of an example Deployment Config Map that sets this value to 10 minutes:

```yaml
apiVersion: v1
kind: ConfigMap
metadata:
name: config-deployment
namespace: knative-serving
labels:
serving.knative.dev/release: devel
annotations:
knative.dev/example-checksum: "fa67b403"
data:
progress-deadline: "10m"
```
Progress deadline setting can be configured at global level through a ConfigMap or at the per-revision level using an annotation.

* **Global key:** `progress-deadline`
* **Per-revision annotation key:** `serving.knative.dev/progress-deadline`
* **Possible values:** `time.Duration`
* **Default:** `"600s"`

**Example:**

=== "Global (ConfigMap)"
```yaml
apiVersion: v1
kind: ConfigMap
metadata:
name: config-deployment
namespace: knative-serving
labels:
serving.knative.dev/release: devel
annotations:
knative.dev/example-checksum: "fa67b403"
data:
progress-deadline: "10m"
```

=== "Per Revision"
```yaml
apiVersion: serving.knative.dev/v1
kind: Service
metadata:
name: helloworld-go
spec:
template:
metadata:
annotations:
serving.knative.dev/progress-deadline: "60s"
spec:
containers:
- image: ghcr.io/knative/helloworld-go:latest
```

## Skipping tag resolution

Expand Down

0 comments on commit 9f47cc5

Please sign in to comment.