From 9f47cc50b319a96e11b2823616801376eefda4dd Mon Sep 17 00:00:00 2001 From: Knative Prow Robot Date: Tue, 28 Nov 2023 15:48:05 +0000 Subject: [PATCH] change in doc - progress deadline annotation on per revision basis (#5777) Co-authored-by: navinag1989 --- docs/serving/configuration/deployment.md | 54 +++++++++++++++++------- 1 file changed, 39 insertions(+), 15 deletions(-) diff --git a/docs/serving/configuration/deployment.md b/docs/serving/configuration/deployment.md index f2a134fc92..280a5820b1 100644 --- a/docs/serving/configuration/deployment.md +++ b/docs/serving/configuration/deployment.md @@ -73,21 +73,45 @@ You may want to configure this setting as a higher value if any of the following See the [Kubernetes documentation](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#progress-deadline-seconds) for more information. -The following example shows a snippet of an example Deployment Config Map that sets this value to 10 minutes: - -```yaml -apiVersion: v1 -kind: ConfigMap -metadata: - name: config-deployment - namespace: knative-serving - labels: - serving.knative.dev/release: devel - annotations: - knative.dev/example-checksum: "fa67b403" -data: - progress-deadline: "10m" -``` +Progress deadline setting can be configured at global level through a ConfigMap or at the per-revision level using an annotation. + +* **Global key:** `progress-deadline` +* **Per-revision annotation key:** `serving.knative.dev/progress-deadline` +* **Possible values:** `time.Duration` +* **Default:** `"600s"` + +**Example:** + +=== "Global (ConfigMap)" + ```yaml + apiVersion: v1 + kind: ConfigMap + metadata: + name: config-deployment + namespace: knative-serving + labels: + serving.knative.dev/release: devel + annotations: + knative.dev/example-checksum: "fa67b403" + data: + progress-deadline: "10m" + ``` + +=== "Per Revision" + ```yaml + apiVersion: serving.knative.dev/v1 + kind: Service + metadata: + name: helloworld-go + spec: + template: + metadata: + annotations: + serving.knative.dev/progress-deadline: "60s" + spec: + containers: + - image: ghcr.io/knative/helloworld-go:latest + ``` ## Skipping tag resolution