Intro to open source with knative blog series p0 and p1 #5618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Calum Murray <cmurray@redhat.com>
knative-prow
bot
added
the
do-not-merge/work-in-progress
knative-prow
bot
added
the
size/M
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Leo6Leo
reviewed
Jun 29, 2023
Co-authored-by: Leo Li <leoli@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
knative-prow
bot
added
size/L
Cali0707
changed the title
knative-prow
bot
removed
the
do-not-merge/work-in-progress
|
/hold until @Leo6Leo adds images, but the content itself is ready for review |
knative-prow
bot
added
the
do-not-merge/hold
Co-authored-by: Leo Li <leoli@redhat.com>
Co-authored-by: Leo Li <leoli@redhat.com>
Co-authored-by: Leo Li <leoli@redhat.com>
Co-authored-by: Leo Li <leoli@redhat.com>
Co-authored-by: Leo Li <leoli@redhat.com>
Co-authored-by: Leo Li <leoli@redhat.com>
Co-authored-by: Leo Li <leoli@redhat.com>
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
creydr
reviewed
Jul 7, 2023
Signed-off-by: Calum Murray <cmurray@redhat.com> Co-authored-by: Christoph Stäbler <cstabler@redhat.com>
|
@creydr I think i have addressed all your comments, could you review when you have time? |
Signed-off-by: Calum Murray <cmurray@redhat.com>
Leo6Leo
reviewed
Jul 11, 2023
Leo6Leo
reviewed
Jul 11, 2023
Leo6Leo
reviewed
Jul 11, 2023
Co-authored-by: Leo Li <leoli@redhat.com>
Co-authored-by: Leo Li <leoli@redhat.com>
Co-authored-by: Leo Li <leoli@redhat.com>
|
/lgtm |
|
/approve |
knative-prow
bot
added
the
approved
|
/hold unhold once ready |
knative-prow
bot
added
the
do-not-merge/hold
psschwei
reviewed
Jul 11, 2023
Co-authored-by: Paul Schweigert <paul@paulschweigert.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi, psschwei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
knative-prow
bot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a draft of the first post in the blog series we proposed recently to make it easier for new contributors to contribute code. The proposal can be seen here
Proposed Changes
We want to publish the first two posts together, so this PR will be in draft status until the second post is also ready