Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #5716

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Update README.md #5716

merged 1 commit into from
Oct 13, 2023

Conversation

SYK-08
Copy link
Contributor

@SYK-08 SYK-08 commented Oct 13, 2023

"Fixes #issue-number" or "Add description of the problem this PR solves"

Proposed Changes

Corrected some grammatical errors in docs/README.md and made it sound more confident and friendly.

@knative-prow knative-prow bot requested review from skonto and snneji October 13, 2023 04:59
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 13, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: SYK-08 / name: Shreyash Kashyap (1947173)

@netlify
Copy link

netlify bot commented Oct 13, 2023 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1947173
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/6528cea5773a6000089b35ad
😎 Deploy Preview https://deploy-preview-5716--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 13, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 13, 2023

Welcome @SYK-08! It looks like this is your first PR to knative/docs 🎉

ReToCode
ReToCode approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, SYK-08

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2023
@ReToCode
Copy link
Member

Thank you @SYK-08

@SYK-08
Copy link
Contributor Author

SYK-08 commented Oct 13, 2023

Thank you @SYK-08

Most welcome 😁

@knative-prow knative-prow bot merged commit 868e904 into knative:main Oct 13, 2023
18 checks passed
@SYK-08 SYK-08 deleted the patch-1 branch October 13, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode ReToCode approved these changes

@skonto skonto Awaiting requested review from skonto

@snneji snneji Awaiting requested review from snneji

Assignees

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SYK-08 @ReToCode