Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use links to artifact on uninstall page #5836

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

prushh
Copy link
Contributor

@prushh prushh commented Jan 28, 2024

Fixes #5835

Proposed Changes

  • Use artifact function to retrieve release links on Uninstalling Knative page, for the following files:
    • serving-core.yaml
    • serving-crds.yaml
    • eventing-core.yaml
    • eventing-crds.yaml

@knative-prow knative-prow bot requested review from aliok and creydr January 28, 2024 12:05
Copy link

netlify bot commented Jan 28, 2024

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit dc9008d
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/65b643081f612e000860721d
😎 Deploy Preview https://deploy-preview-5836--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 28, 2024
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2024
Copy link

knative-prow bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prushh, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2024
@ReToCode
Copy link
Member

/cherry-pick release-1.13

@knative-prow knative-prow bot merged commit ac6efa8 into knative:main Jan 29, 2024
19 checks passed
@knative-prow-robot
Copy link
Contributor

@ReToCode: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot
Copy link
Contributor

@ReToCode: new pull request created: #5838

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links for uninstalling serving and eventing are nightly
3 participants