Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish the article "Demysifying the activator on data path" #5922

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Polish the article "Demysifying the activator on data path" #5922

merged 3 commits into from
Mar 22, 2024

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Mar 21, 2024 •
edited
Loading

Proposed Changes

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 21, 2024
@knative-prow knative-prow bot requested review from nainaz and pmbanugo March 21, 2024 15:40
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 21, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 21, 2024 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 249f8f0
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/65fc57cb9b6b090008c96aac
😎 Deploy Preview https://deploy-preview-5922--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@skonto skonto requested review from psschwei and removed request for pmbanugo and nainaz March 21, 2024 15:41
@skonto skonto changed the title [wip] Polish the article "Demysifying the activator on data path" Polish the article "Demysifying the activator on data path" Mar 21, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2024
psschwei
psschwei reviewed Mar 22, 2024
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Mar 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psschwei, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 70684b4 into knative:main Mar 22, 2024
19 checks passed
prushh pushed a commit to prushh/docs that referenced this pull request Apr 30, 2024
@skonto @prushh
Polish the article "Demysifying the activator on data path" (knative#…
d3041ae 
…5922)

* Polish the article

* fix

* move around a few stuff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psschwei psschwei psschwei left review comments

Assignees

@psschwei psschwei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skonto @psschwei