Migrate from istio inject annotation to label #8204
Assignees
Comments
|
@ReToCode when was the first release the support for the label was added ? do we want to keep annotation and label to support older versions? |
pierDipi
added a commit
to pierDipi/eventing-kafka-broker
that referenced
this issue
Sep 24, 2024
Ref: knative/eventing#8204 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
|
Support was added in 1.11 (https://istio.io/latest/news/releases/1.11.x/announcing-1.11/#updates-to-revision-and-tag-deployments). So I think this should be fine? |
pierDipi
added a commit
to pierDipi/reconciler-test
that referenced
this issue
Sep 26, 2024
Ref: knative/eventing#8204 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
This was referenced Sep 26, 2024
Merged
pierDipi
added a commit
to pierDipi/reconciler-test
that referenced
this issue
Sep 26, 2024
Ref: knative/eventing#8204 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
knative-prow bot
pushed a commit
to knative-extensions/reconciler-test
that referenced
this issue
Sep 26, 2024
Ref: knative/eventing#8204 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
knative-prow-robot
pushed a commit
to knative-prow-robot/reconciler-test
that referenced
this issue
Sep 26, 2024
Ref: knative/eventing#8204 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
matzew
pushed a commit
to matzew/eventing-kafka-broker
that referenced
this issue
Sep 27, 2024
Ref: knative/eventing#8204 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
knative-prow bot
pushed a commit
to knative-extensions/reconciler-test
that referenced
this issue
Sep 27, 2024
Ref: knative/eventing#8204 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
knative-prow bot
pushed a commit
to knative-extensions/eventing-kafka-broker
that referenced
this issue
Oct 2, 2024
Ref: knative/eventing#8204 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
added a commit
to openshift-knative/eventing-kafka-broker
that referenced
this issue
Oct 8, 2024
Ref: knative/eventing#8204 Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
We use the istio annotation
sidecar.istio.io/inject: truein various places in Eventing and related extension repos. Istio deprecated the annotation a while ago (ref: https://istio.io/latest/docs/reference/config/analysis/ist0135/ and https://istio.io/latest/docs/reference/config/annotations/#SidecarInject). Downstream this starts to cause issues (e.g. with OSSM 3.x), so we should migrate to the according label.cc @pierDipi @creydr this came up here. I was unable to get the "old" way to work with OSSM 3.x, but we probably should migrate to the label anyway (we updated the docs for the customer to do the same).
The text was updated successfully, but these errors were encountered: