Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update Go version in prow-tests image #130

Merged
merged 1 commit into from
Jul 18, 2023
Merged

chore: Update Go version in prow-tests image #130

merged 1 commit into from
Jul 18, 2023

Conversation

dsimansk
Copy link
Contributor

Bump Go version in prow-tests before next release per @dprotaso suggestion.

/cc @dprotaso
/cc @knative/knative-release-leads

@knative-prow knative-prow bot requested review from dprotaso and a team July 17, 2023 09:23
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2023
pierDipi
pierDipi approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2023
@dsimansk
Copy link
Contributor Author

/test pull-knative-infra-prow-tests-image-build

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2023
@dsimansk
Copy link
Contributor Author

Should we bump the debian image from bullseye to bookworm? Or just add CGO_ENABLE=0?

See: golang/go#58550

/cc @knative/productivity-leads

 #71 [stage-5 12/14] RUN rm -f /usr/local/bin/source-gvm-and-run.sh
#71 DONE 0.1s
#72 [stage-5 13/14] RUN ko version > /ko_version
#0 0.084 ko: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by ko)
#0 0.084 ko: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by ko)
#72 ERROR: process "/bin/sh -c ko version > /ko_version" did not complete successfully: exit code: 1
------
 > [stage-5 13/14] RUN ko version > /ko_version:
#0 0.084 ko: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by ko)
#0 0.084 ko: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by ko)
------
Dockerfile:281
--------------------
 279 |     
 280 |     # Extract versions
 281 | >>> RUN ko version > /ko_version
 282 |     
 283 |     # Ensure docker config is in the final image
--------------------
ERROR: failed to solve: process "/bin/sh -c ko version > /ko_version" did not complete successfully: exit code: 1
ERROR
ERROR: build step 0 "gcr.io/k8s-testimages/gcb-docker-gcloud" failed: step exited with non-zero status: 1
--------------------------------------------------------------------------------
make: *** [Makefile:25: build-ci-test] Error 1
make: Leaving directory '/home/prow/go/src/knative.dev/infra/images/prow-tests'
+ EXIT_VALUE=2
+ set +o xtrace

@knative-prow knative-prow bot requested a review from a team July 17, 2023 13:00
upodroid
upodroid requested changes Jul 17, 2023
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can go ahead and add it, assuming it doesn't break serving, eventing, etc

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2023
@dsimansk
Copy link
Contributor Author

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2023
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 18, 2023
dsimansk
dsimansk commented Jul 18, 2023
View reviewed changes
images/prow-tests/Dockerfile
Comment on lines +188 to +190
# Disable CGO libs to avoid error with too old version in base image
ENV CGO_ENABLED=0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@upodroid the image builds fine with CGO_ENABLED. Is there a way to verify Serving, Eventing other than merging the PR and runnings builds on the respective repos afterwards.

@dsimansk
Copy link
Contributor Author

/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 18, 2023
upodroid
upodroid approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we have to use the image and see what happens.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 18, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, pierDipi, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 833225a into main Jul 18, 2023
12 checks passed
@pierDipi pierDipi deleted the pr/bump-go-prow-tests branch July 18, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

@pierDipi pierDipi pierDipi approved these changes

@dprotaso dprotaso Awaiting requested review from dprotaso

Assignees

@upodroid upodroid

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsimansk @upodroid @pierDipi