Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update Go version in prow-tests image #130

Merged
merged 1 commit into from
Jul 18, 2023
Merged

chore: Update Go version in prow-tests image #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions images/prow-tests/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,11 +161,11 @@ RUN curl -fsSL "https://github.com/protocolbuffers/protobuf/releases/download/v$
# protoc-gen-gogofaster is installed below

############################################################
FROM golang:1.19.9 AS external-go-previous
FROM golang:1.19.11 AS external-go-previous
# Capture the version that dependabot bumps so that we can install it into the base image
RUN go version | cut -d' ' -f3 > /golang.version

FROM golang:1.20.4 AS external-go-latest
FROM golang:1.20.6 AS external-go-latest
# Capture the version that dependabot bumps so that we can install it into the base image
RUN go version | cut -d' ' -f3 > /golang.version

Expand All @@ -185,6 +185,9 @@ ARG JSONNET_VERSION=v0.18.0
ARG COSIGN_VERSION=v1.13.0
ARG TOOLBOX_VERSION=2051540f04c2a8fb5ad50c717345c2dd69a0b71e

# Disable CGO libs to avoid error with too old version in base image
ENV CGO_ENABLED=0

Comment on lines +188 to +190
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@upodroid the image builds fine with CGO_ENABLED. Is there a way to verify Serving, Eventing other than merging the PR and runnings builds on the respective repos afterwards.

# Extra tools through go install
# These run using the golang image version of Go, not any defined by `gvm`
RUN go install github.com/google/ko@${KO_VERSION}
Expand Down
2 changes: 1 addition & 1 deletion images/tool/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM golang:1.20.4
FROM golang:1.20.6

# Required input: -e TOOL_NAME=name, i.e. TOOL_NAME=flaky-test-reporter
ARG TOOL_NAME
Expand Down
Loading