Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[s390x] adding support for release 1.11 #148

Merged
merged 2 commits into from
Jul 28, 2023
Merged

[s390x] adding support for release 1.11 #148

merged 2 commits into from
Jul 28, 2023

Conversation

dilipgb
Copy link
Contributor

@dilipgb dilipgb commented Jul 28, 2023

This PR updates the s390x-related prow jobs for release 1.11.

@knative-prow knative-prow bot requested review from psschwei and upodroid July 28, 2023 11:33
@knative-prow knative-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 28, 2023
@dilipgb
Copy link
Contributor Author

dilipgb commented Jul 28, 2023

@upodroid @psschwei can you please take a look at this PR. Thanks!!

psschwei
psschwei reviewed Jul 28, 2023
View reviewed changes
Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dilipgb, psschwei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2023
@knative-prow knative-prow bot merged commit 7869549 into knative:main Jul 28, 2023
12 checks passed
@knative-prow
Copy link

knative-prow bot commented Jul 28, 2023

@dilipgb: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key eventing-kafka-broker-release-1.11.gen.yaml using file prow/jobs/generated/knative-sandbox/eventing-kafka-broker-release-1.11.gen.yaml
  • key eventing-kafka-release-1.11.gen.yaml using file prow/jobs/generated/knative-sandbox/eventing-kafka-release-1.11.gen.yaml
  • key kn-plugin-event-release-1.11.gen.yaml using file prow/jobs/generated/knative-sandbox/kn-plugin-event-release-1.11.gen.yaml
  • key client-release-1.11.gen.yaml using file prow/jobs/generated/knative/client-release-1.11.gen.yaml
  • key eventing-release-1.11.gen.yaml using file prow/jobs/generated/knative/eventing-release-1.11.gen.yaml
  • key serving-release-1.11.gen.yaml using file prow/jobs/generated/knative/serving-release-1.11.gen.yaml

In response to this:

This PR updates the s390x-related prow jobs for release 1.11.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psschwei psschwei psschwei left review comments

@upodroid upodroid Awaiting requested review from upodroid

Assignees

@psschwei psschwei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dilipgb @psschwei