Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inaccurate instruction for internal-encryption #846

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Fix inaccurate instruction for internal-encryption #846

merged 1 commit into from
Aug 30, 2023

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Aug 28, 2023

Fix the comment in the config map as neither internal-dataplane-trust nor internal-controlplane-trust exists.

Release Note

NONE

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2023
@knative-prow knative-prow bot requested a review from skonto August 28, 2023 04:40
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1d7920d) 82.50% compared to head (1ab3726) 82.50%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #846   +/-   ##
=======================================
  Coverage   82.50%   82.50%           
=======================================
  Files          45       45           
  Lines        1715     1715           
=======================================
  Hits         1415     1415           
  Misses        259      259           
  Partials       41       41

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ReToCode
ReToCode approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 30, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit dfd6edf into knative:main Aug 30, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode ReToCode approved these changes

@skonto skonto Awaiting requested review from skonto

@xtreme-vikram-yadav xtreme-vikram-yadav Awaiting requested review from xtreme-vikram-yadav

Assignees

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nak3 @ReToCode