-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve InternalTLSEnabled util function #847
Conversation
Currently `InternalTLSEnabled()` has two issues such as: * `true` is returned when `dataplane-trust` is not configured. * `controlplane-trust` is not considered. This patch improves these issues.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #847 +/- ##
==========================================
- Coverage 82.50% 82.26% -0.24%
==========================================
Files 45 45
Lines 1715 1720 +5
==========================================
Hits 1415 1415
- Misses 259 264 +5
Partials 41 41
☔ View full report in Codecov by Sentry. |
496cb74
to
d0624a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Currently
InternalTLSEnabled()
has two issues such as:true
is returned whendataplane-trust
is not configured. (The current default isdisabled
.)controlplane-trust
is not considered.This patch improves these issues.
/kind enhancement
Release Note