Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Upgrade to latest dependencies #929

Merged
merged 1 commit into from
Feb 21, 2024
Merged

[main] Upgrade to latest dependencies #929

merged 1 commit into from
Feb 21, 2024

Conversation

knative-automation
Copy link
Contributor

@knative-automation knative-automation commented Feb 21, 2024 •
edited
Loading

drop toolchain directive -dprotaso

/cc knative/serving-writers
/assign knative/serving-writers

Produced by: knative-extensions/knobots/actions/update-deps

@knative-prow knative-prow bot requested a review from a team February 21, 2024 01:26
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 21, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f5845ef) 94.05% compared to head (a4f61e6) 94.05%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #929   +/-   ##
=======================================
  Coverage   94.05%   94.05%           
=======================================
  Files          42       42           
  Lines        1311     1311           
=======================================
  Hits         1233     1233           
  Misses         65       65           
  Partials       13       13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ReToCode
Copy link
Member

needs knative/pkg#2966

@ReToCode
Copy link
Member

/test build-tests

ReToCode
ReToCode reviewed Feb 21, 2024
View reviewed changes
go.mod Outdated
go 1.18
go 1.21

toolchain go1.21.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably do not (yet) want toolchain here

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2024
@knative-automation
upgrade to latest dependencies
a4f61e6 
Signed-off-by: Knative Automation <automation@knative.team>
@dprotaso
Copy link
Member

dprotaso commented Feb 21, 2024 •
edited
Loading

hack changes worked - we're dropping the toolchain directive now

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-automation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2024
@dprotaso
Copy link
Member

/hold cancel

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2024
@knative-prow knative-prow bot merged commit 8bbc041 into knative:main Feb 21, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReToCode ReToCode ReToCode left review comments

Assignees

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knative-automation @ReToCode @dprotaso