Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix TestRetry nil pointer panic #965

Merged
merged 1 commit into from
Apr 11, 2024
+2 −2
Merged

fix TestRetry nil pointer panic #965

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/conformance/ingress/retry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ func TestRetry(t *testing.T) {
// automatically and the service only responds 200 on the _second_ access.
resp, err := client.Get("http://" + domain)
if err != nil {
t.Errorf("Error making GET request: %v", err)
t.Fatalf("Error making GET request: %v", err)
}
defer resp.Body.Close()
if resp.StatusCode != http.StatusServiceUnavailable {
Expand All @@ -67,7 +67,7 @@ func TestRetry(t *testing.T) {
// Second try - this time we should succeed.
resp, err = client.Get("http://" + domain)
if err != nil {
t.Errorf("Error making GET request: %v", err)
t.Fatalf("Error making GET request: %v", err)
}
defer resp.Body.Close()
if resp.StatusCode != http.StatusOK {
Expand Down
Loading