-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return Audience in URIResolver.AddressableFromDestinationV1() too #2836
Return Audience in URIResolver.AddressableFromDestinationV1() too #2836
Conversation
/assign @pierDipi |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2836 +/- ##
==========================================
+ Coverage 81.81% 81.86% +0.05%
==========================================
Files 167 167
Lines 10217 10224 +7
==========================================
+ Hits 8359 8370 +11
+ Misses 1612 1608 -4
Partials 246 246
☔ View full report in Codecov by Sentry. |
/test unit-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
URIResolver.AddressableFromDestinationV1()
returns now the Audience of the Destination/target too