Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.10] Bumped x/net to v0.17.0 to fix cve-2023-44487 #2862

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

Cali0707
Copy link
Member

Fix cve-2023-44487 by bumping our x/net version

Changes

  • Bump x/net to v0.17.0

Release Note

Fix CVE-2023-44487

Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 11, 2023
@Cali0707
Copy link
Member Author

/cc @dsimansk @dprotaso

@dprotaso dprotaso changed the title Bumped x/net to v0.17.0 to fix cve-2023-44487 on release-1.10 [release-1.10] Bumped x/net to v0.17.0 to fix cve-2023-44487 Oct 11, 2023
@dprotaso
Copy link
Member

/retest

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (dfad48e) 81.52% compared to head (d453dcb) 81.52%.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-1.10    #2862   +/-   ##
=============================================
  Coverage         81.52%   81.52%           
=============================================
  Files               163      163           
  Lines              9954     9954           
=============================================
  Hits               8115     8115           
  Misses             1596     1596           
  Partials            243      243           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cali0707
Copy link
Member Author

Cali0707 commented Oct 11, 2023

@dprotaso it looks like the serving, net-kourier, and net-countour unit tests are having issues resolving control-protocol, could this have something to do with the repo being archived in June?

  go: knative.dev/control-protocol@v0.0.0-20230420145039-d9cda76c5b03: unrecognized import path "knative.dev/control-protocol": reading https://knative.dev/control-protocol?go-get=1: 404 Not Found
  go: downloading knative.dev/control-protocol v0.0.0-20230420145039-d9cda76c5b03
  go: knative.dev/control-protocol@v0.0.0-20230420145039-d9cda76c5b03: unrecognized import path "knative.dev/control-protocol": reading https://knative.dev/control-protocol?go-get=1: 404 Not Found

@dprotaso
Copy link
Member

Fixed the redirects - they were removed when we archived

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 11, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2023
@knative-prow knative-prow bot merged commit df28fea into knative:release-1.10 Oct 11, 2023
34 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants