Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print each line separately in shell executor #2867

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Print each line separately in shell executor #2867

merged 1 commit into from
Oct 16, 2023

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Oct 16, 2023

This is a follow-up on knative/serving#14495 (comment)

Changes

  • Prints each line separately so that the output is nicely formatted:
{Failed  === RUN   TestServingUpgrades/Run/Steps/UpgradeWith/ServingHead
    executor.go:189: Oct 16 07:12:49.696 install_head_reuse_ingress [OUT] =============================================================
    executor.go:189: Oct 16 07:12:49.696 install_head_reuse_ingress [OUT] ==== INSTALLING KNATIVE HEAD RELEASE AND REUSING INGRESS ====
    executor.go:189: Oct 16 07:12:49.696 install_head_reuse_ingress [OUT] =============================================================
    executor.go:189: Oct 16 07:12:49.698 install_head_reuse_ingress [OUT] ==== 2023-10-16 07:12:49.697870734+00:00
    executor.go:189: Oct 16 07:12:49.698 install_head_reuse_ingress [OUT] =============================================================
    executor.go:189: Oct 16 07:12:49.699 install_head_reuse_ingress [ERR] test/e2e-common.sh: line 499: install-nonexistent: command not found
    executor.go:189: Oct 16 07:12:49.700 install_head_reuse_ingress [OUT] ***************************************
    executor.go:189: Oct 16 07:12:49.700 install_head_reuse_ingress [OUT] ***         E2E TEST FAILED         ***
    executor.go:189: Oct 16 07:12:49.700 install_head_reuse_ingress [OUT] ***    Start of information dump    ***
    executor.go:189: Oct 16 07:12:49.700 install_head_reuse_ingress [OUT] ***************************************
    executor.go:189: Oct 16 07:12:49.701 install_head_reuse_ingress [OUT] >>> The dump is located at /logs/artifacts/k8s.dump-.txt
    executor.go:189: Oct 16 07:12:50.080 install_head_reuse_ingress [OUT] >>> allowlistedv2workloads.auto.gke.io (0 objects)
    executor.go:189: Oct 16 07:12:50.286 install_head_reuse_ingress [OUT] >>> allowlistedworkloads.auto.gke.io (0 objects)

instead of

{Failed  === RUN   TestServingUpgrades/Run/Steps/UpgradeWith/ServingHead
    executor.go:207: Oct 12 07:08:25.735 install_head_reuse_ingress [OUT] =============================================================
        Oct 12 07:08:25.735 install_head_reuse_ingress [OUT] ==== INSTALLING KNATIVE HEAD RELEASE AND REUSING INGRESS ====
        Oct 12 07:08:25.735 install_head_reuse_ingress [OUT] =============================================================
    executor.go:207: Oct 12 07:08:25.737 install_head_reuse_ingress [OUT] ==== 2023-10-12 07:08:25.736830951+00:00
        Oct 12 07:08:25.737 install_head_reuse_ingress [OUT] =============================================================
    executor.go:207: Oct 12 07:08:25.737 install_head_reuse_ingress [ERR] test/e2e-common.sh: line 499: install-nonexistent: command not found
    executor.go:207: Oct 12 07:08:25.738 install_head_reuse_ingress [OUT] ***************************************
        Oct 12 07:08:25.738 install_head_reuse_ingress [OUT] ***         E2E TEST FAILED         ***
        Oct 12 07:08:25.738 install_head_reuse_ingress [OUT] ***    Start of information dump    ***
        Oct 12 07:08:25.738 install_head_reuse_ingress [OUT] ***************************************
    executor.go:207: Oct 12 07:08:25.739 install_head_reuse_ingress [OUT] >>> The dump is located at /logs/artifacts/k8s.dump-.txt

/kind

Fixes #

Release Note

Docs

@knative-prow
Copy link

knative-prow bot commented Oct 16, 2023

@mgencur: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

This is a follow-up on knative/serving#14495 (comment)

Changes

  • Prints each line separately so that the output is nicely formatted:
{Failed  === RUN   TestServingUpgrades/Run/Steps/UpgradeWith/ServingHead
   executor.go:189: Oct 16 07:12:49.696 install_head_reuse_ingress [OUT] =============================================================
   executor.go:189: Oct 16 07:12:49.696 install_head_reuse_ingress [OUT] ==== INSTALLING KNATIVE HEAD RELEASE AND REUSING INGRESS ====
   executor.go:189: Oct 16 07:12:49.696 install_head_reuse_ingress [OUT] =============================================================
   executor.go:189: Oct 16 07:12:49.698 install_head_reuse_ingress [OUT] ==== 2023-10-16 07:12:49.697870734+00:00
   executor.go:189: Oct 16 07:12:49.698 install_head_reuse_ingress [OUT] =============================================================
   executor.go:189: Oct 16 07:12:49.699 install_head_reuse_ingress [ERR] test/e2e-common.sh: line 499: install-nonexistent: command not found
   executor.go:189: Oct 16 07:12:49.700 install_head_reuse_ingress [OUT] ***************************************
   executor.go:189: Oct 16 07:12:49.700 install_head_reuse_ingress [OUT] ***         E2E TEST FAILED         ***
   executor.go:189: Oct 16 07:12:49.700 install_head_reuse_ingress [OUT] ***    Start of information dump    ***
   executor.go:189: Oct 16 07:12:49.700 install_head_reuse_ingress [OUT] ***************************************
   executor.go:189: Oct 16 07:12:49.701 install_head_reuse_ingress [OUT] >>> The dump is located at /logs/artifacts/k8s.dump-.txt
   executor.go:189: Oct 16 07:12:50.080 install_head_reuse_ingress [OUT] >>> allowlistedv2workloads.auto.gke.io (0 objects)
   executor.go:189: Oct 16 07:12:50.286 install_head_reuse_ingress [OUT] >>> allowlistedworkloads.auto.gke.io (0 objects)

instead of

{Failed  === RUN   TestServingUpgrades/Run/Steps/UpgradeWith/ServingHead
   executor.go:207: Oct 12 07:08:25.735 install_head_reuse_ingress [OUT] =============================================================
       Oct 12 07:08:25.735 install_head_reuse_ingress [OUT] ==== INSTALLING KNATIVE HEAD RELEASE AND REUSING INGRESS ====
       Oct 12 07:08:25.735 install_head_reuse_ingress [OUT] =============================================================
   executor.go:207: Oct 12 07:08:25.737 install_head_reuse_ingress [OUT] ==== 2023-10-12 07:08:25.736830951+00:00
       Oct 12 07:08:25.737 install_head_reuse_ingress [OUT] =============================================================
   executor.go:207: Oct 12 07:08:25.737 install_head_reuse_ingress [ERR] test/e2e-common.sh: line 499: install-nonexistent: command not found
   executor.go:207: Oct 12 07:08:25.738 install_head_reuse_ingress [OUT] ***************************************
       Oct 12 07:08:25.738 install_head_reuse_ingress [OUT] ***         E2E TEST FAILED         ***
       Oct 12 07:08:25.738 install_head_reuse_ingress [OUT] ***    Start of information dump    ***
       Oct 12 07:08:25.738 install_head_reuse_ingress [OUT] ***************************************
   executor.go:207: Oct 12 07:08:25.739 install_head_reuse_ingress [OUT] >>> The dump is located at /logs/artifacts/k8s.dump-.txt

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added area/test-and-release size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2023
@mgencur mgencur mentioned this pull request Oct 16, 2023
Merged
@codecov
Copy link

codecov bot commented Oct 16, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9051a45) 81.83% compared to head (aea35d7) 81.80%.
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2867      +/-   ##
==========================================
- Coverage   81.83%   81.80%   -0.03%     
==========================================
  Files         167      167              
  Lines       10227    10227              
==========================================
- Hits         8369     8366       -3     
- Misses       1612     1614       +2     
- Partials      246      247       +1

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2023
@knative-prow
Copy link

knative-prow bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2023
@knative-prow knative-prow bot merged commit 0d0cd4e into knative:main Oct 16, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr Awaiting requested review from creydr

@evankanderson evankanderson Awaiting requested review from evankanderson

Assignees

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgencur @dprotaso