-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop toolchain directive #2966
drop toolchain directive #2966
Conversation
client failures are expected - k8s client-go had breaking changes |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2966 +/- ##
=======================================
Coverage 81.80% 81.80%
=======================================
Files 167 167
Lines 10231 10231
=======================================
Hits 8369 8369
Misses 1614 1614
Partials 248 248 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
We really need to remove that licence-tool. go xxx
will always re-introduce that directive when the version changes.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I missed that we bumped some non-dependency properties in the go.mod file in #2964
We shouldn't need to specify the
toolchain
directive - this oddly this breaks our go-licenses tool.Bumping go version to v1.21 should be fine
see failure: knative-extensions/net-http01#593
/assign @izabelacg @ReToCode @skonto