Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop toolchain directive #2966

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Feb 21, 2024

I missed that we bumped some non-dependency properties in the go.mod file in #2964

We shouldn't need to specify the toolchain directive - this oddly this breaks our go-licenses tool.

Bumping go version to v1.21 should be fine

see failure: knative-extensions/net-http01#593

/assign @izabelacg @ReToCode @skonto

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 21, 2024
@dprotaso
Copy link
Member Author

client failures are expected - k8s client-go had breaking changes

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4fba530) 81.80% compared to head (d817856) 81.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2966   +/-   ##
=======================================
  Coverage   81.80%   81.80%           
=======================================
  Files         167      167           
  Lines       10231    10231           
=======================================
  Hits         8369     8369           
  Misses       1614     1614           
  Partials      248      248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

We really need to remove that licence-tool. go xxx will always re-introduce that directive when the version changes.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2024
Copy link

knative-prow bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants