Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop http01 from downstream testing #2968

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

dprotaso
Copy link
Member

This is deprecated - knative/serving#14640

Copy link

knative-prow bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 21, 2024
@dprotaso
Copy link
Member Author

/assign @izabelacg

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9f033a7) 81.80% compared to head (e3e4b17) 81.82%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2968      +/-   ##
==========================================
+ Coverage   81.80%   81.82%   +0.02%     
==========================================
  Files         167      167              
  Lines       10231    10231              
==========================================
+ Hits         8369     8372       +3     
+ Misses       1614     1612       -2     
+ Partials      248      247       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@izabelacg
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2024
@knative-prow knative-prow bot merged commit 695c421 into knative:main Feb 21, 2024
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants