Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop eventing kafka from downstream tests - repo is archived #3061

Merged
merged 1 commit into from
Jun 20, 2024
Merged

drop eventing kafka from downstream tests - repo is archived #3061

merged 1 commit into from
Jun 20, 2024

Conversation

dprotaso
Copy link
Member

/assign @pierDipi

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 20, 2024
@knative-prow knative-prow bot requested review from aslom and creydr June 20, 2024 15:27
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2024
pierDipi
pierDipi approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jun 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member

pierDipi commented Jun 20, 2024 •
edited
Loading

Flake

--- FAIL: TestNamespaceStream (0.40s)
    stream_test.go:316: Log was still produced, trying again...
    stream_test.go:323: No watching should have happened context canceled
FAIL
coverage: 87.0% of statements

@knative-prow knative-prow bot merged commit fe2597a into knative:main Jun 20, 2024
34 checks passed
@dprotaso dprotaso deleted the eventing-kafka-drop branch June 20, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@aslom aslom Awaiting requested review from aslom

@creydr creydr Awaiting requested review from creydr

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dprotaso @pierDipi