Fix rand source in name

[skonto]

Changes

• Fixes issue with rand source concurrent access. See [wip] [test-only] Rand fix serving#15354

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.45%. Comparing base (26bc7b4) to head (affc81c).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3070   +/-   ##
=======================================
  Coverage   78.44%   78.45%           
=======================================
  Files         191      191           
  Lines        8941     8938    -3     
=======================================
- Hits         7014     7012    -2     
+ Misses       1664     1663    -1     
  Partials      263      263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dprotaso]

minor tweak - let's just do a defer unlock

Suggested change

	nameMu.Lock()
	for i := range suffix {
	suffix[i] = letterBytes[nameRand.Intn(len(letterBytes))]
	}
	nameMu.Unlock()
	nameMu.Lock()
	defer nameMu.Unlock()
	for i := range suffix {
	suffix[i] = letterBytes[nameRand.Intn(len(letterBytes))]
	}

[dprotaso]

actually let's get this merged - the change can be done in a follow up

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/OWNERS [dprotaso,skonto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment