Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.16] Fix WEBHOOK_DISABLE_NAMESPACE_OWNERSHIP env-var #3108

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #3107

Fixed `WEBHOOK_DISABLE_NAMESPACE_OWNERSHIP` env-var

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.29%. Comparing base (4af9a0d) to head (0857940).
Report is 1 commits behind head on release-1.16.

Files with missing lines Patch % Lines
webhook/configmaps/controller.go 40.00% 2 Missing and 1 partial ⚠️
webhook/resourcesemantics/defaulting/controller.go 25.00% 2 Missing and 1 partial ⚠️
webhook/resourcesemantics/validation/controller.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.16    #3108      +/-   ##
================================================
- Coverage         78.37%   78.29%   -0.09%     
================================================
  Files               191      191              
  Lines             11177    11186       +9     
================================================
- Hits               8760     8758       -2     
- Misses             2153     2162       +9     
- Partials            264      266       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2024
Copy link

knative-prow bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2024
@knative-prow knative-prow bot merged commit 9b9d535 into knative:release-1.16 Oct 21, 2024
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants