Skip to content

Add startup probe support to Knative Service #10129

Add startup probe support to Knative Service

Add startup probe support to Knative Service #10129

Triggered via pull request July 8, 2024 05:40
Status Success
Total duration 3m 8s
Artifacts

knative-style.yaml

on: pull_request
style  /  changes
2s
style / changes
style  /  ...  /  Auto-format and Check
20s
style / Golang / Auto-format and Check
style  /  ...  /  Lint
2m 51s
style / Golang / Lint
style  /  ...  /  Do Not Submit
8s
style / Golang / Do Not Submit
style  /  ...  /  shell
0s
style / suggester / shell
style  /  ...  /  yaml
24s
style / suggester / yaml
style  /  ...  /  github_actions
0s
style / suggester / github_actions
Matrix: style / Golang / Boilerplate Check
Fit to window
Zoom out
Zoom in

Annotations

12 errors and 5 warnings
style / Golang / Boilerplate Check (sh): hack/boilerplate/add-boilerplate.sh#L1
[Bash headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: hack/boilerplate/add-boilerplate.sh:1: missing boilerplate: #!/usr/bin/env bash # Copyright 2024 The Knative Authors # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to in writing, software # distributed under the License is distributed on an "AS IS" BASIS, # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. # See the License for the specific language governing permissions and # limitations under the License.
style / Golang / Boilerplate Check (sh): test/upload-test-images.sh#L2
[Bash headers] reported by reviewdog 🐶 found mismatched boilerplate lines: Raw Output: test/upload-test-images.sh:2: found mismatched boilerplate lines: {[]string}[0]: -: "" +: "#" {[]string}[7]: -: "# http://www.apache.org/licenses/LICENSE-2.0" +: "# https://www.apache.org/licenses/LICENSE-2.0"
style / Golang / Boilerplate Check (go): pkg/networking/util.go#L1
[Go headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: pkg/networking/util.go:1: missing boilerplate: /* Copyright 2024 The Knative Authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */
style / Golang / Boilerplate Check (go): pkg/networking/util_test.go#L1
[Go headers] reported by reviewdog 🐶 missing boilerplate: Raw Output: pkg/networking/util_test.go:1: missing boilerplate: /* Copyright 2024 The Knative Authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */
style / Golang / Lint: DEVELOPMENT.md#L161
[trailing whitespace] reported by reviewdog 🐶 - By default, `ko` will build container images for the architecture of your local machine, Raw Output: DEVELOPMENT.md:161:- By default, `ko` will build container images for the architecture of your local machine,
style / Golang / Lint: DEVELOPMENT.md#L162
[trailing whitespace] reported by reviewdog 🐶 but if you need to build images for a different platform (OS and architecture), Raw Output: DEVELOPMENT.md:162: but if you need to build images for a different platform (OS and architecture),
style / Golang / Lint: DEVELOPMENT.md#L163
[trailing whitespace] reported by reviewdog 🐶 you can provide `--platform` flag as follows: Raw Output: DEVELOPMENT.md:163: you can provide `--platform` flag as follows:
style / Golang / Lint: docs/encryption/knative-encryption.md#L25
[trailing whitespace] reported by reviewdog 🐶 * These certificates are either [provided manually](https://knative.dev/docs/serving/using-a-tls-cert/) or by using an implementation to the [Knative Certificate abstraction](https://github.com/knative/networking/blob/main/pkg/apis/networking/v1alpha1/certificate_types.go#L34). Currently, we support the [net-certmanager](https://github.com/knative-extensions/net-certmanager) implementation. Raw Output: docs/encryption/knative-encryption.md:25:* These certificates are either [provided manually](https://knative.dev/docs/serving/using-a-tls-cert/) or by using an implementation to the [Knative Certificate abstraction](https://github.com/knative/networking/blob/main/pkg/apis/networking/v1alpha1/certificate_types.go#L34). Currently, we support the [net-certmanager](https://github.com/knative-extensions/net-certmanager) implementation.
style / Golang / Lint: docs/scaling/images/scale-from-0.png#L232
[EOF Newline] reported by reviewdog 🐶 Missing newline Raw Output: docs/scaling/images/scale-from-0.png:232: Missing newline
style / Golang / Lint: docs/scaling/images/scale-to-0.png#L209
[EOF Newline] reported by reviewdog 🐶 Missing newline Raw Output: docs/scaling/images/scale-to-0.png:209: Missing newline
style / Golang / Lint: docs/scaling/images/scale-up-down.png#L200
[EOF Newline] reported by reviewdog 🐶 Missing newline Raw Output: docs/scaling/images/scale-up-down.png:200: Missing newline
style / Golang / Lint: docs/spec/images/object_model.png#L55
[EOF Newline] reported by reviewdog 🐶 Missing newline Raw Output: docs/spec/images/object_model.png:55: Missing newline
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/serving/serving. Supported file pattern: go.sum
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/serving/serving. Supported file pattern: go.sum
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/serving/serving. Supported file pattern: go.sum
style / suggester / yaml
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/serving/serving. Supported file pattern: go.sum