Update TLS test matrix for istio and contour

knative · Jul 15, 2024 · 32dc5c3 · 32dc5c3
1 parent 2156812
commit 32dc5c3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/.github/workflows/kind-e2e.yaml b/.github/workflows/kind-e2e.yaml
@@ -93,6 +93,7 @@ jobs:
         # Disabled due to flakiness: https://github.com/knative/serving/issues/14637
         # - istio-ambient
         - contour
+        - contour-tls
         - gateway_istio
         - gateway_contour
 
@@ -116,6 +117,11 @@ jobs:
         - ingress: contour
           namespace-resources: httpproxy
 
+        - ingress: contour-tls
+          ingress-class: contour
+          namespace-resources: httpproxy
+          enable-tls: 1
+
         - ingress: istio
           namespace-resources: virtualservices
 

diff --git a/test/e2e-common.sh b/test/e2e-common.sh
@@ -389,10 +389,12 @@ function install() {
   fi
 
   if (( ENABLE_TLS )); then
-    echo "Patch config-network to enable encryption features"
-    toggle_feature system-internal-tls enabled config-network
-
-    if [[ "$INGRESS_CLASS" == "kourier.ingress.networking.knative.dev" ]] || [[ "$INGRESS_CLASS" == "istio.ingress.networking.knative.dev" ]]; then
+	  if [[ "$INGRESS_CLASS" == "kourier.ingress.networking.knative.dev" ]] || [[ "$INGRESS_CLASS" == "contour.ingress.networking.knative.dev" ]]; then
+      echo "Patch config-network to enable system-internal-tls feature (kourier/contour)"
+      toggle_feature system-internal-tls enabled config-network
+    fi
+    if [[ "$INGRESS_CLASS" == "kourier.ingress.networking.knative.dev" ]] || [[ "$INGRESS_CLASS" == "istio.ingress.networking.knative.dev" ]] || [[ "$INGRESS_CLASS" == "contour.ingress.networking.knative.dev" ]]; then
+      echo "Patch config-network to enable cluster-local-domain-tls feature (kourier/istio/contour)"
       toggle_feature cluster-local-domain-tls enabled config-network
     fi