Disable flaky ambient e2e tests #14638
Conversation
knative-prow
bot
added
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14638 +/- ##
=======================================
Coverage 86.02% 86.02%
=======================================
Files 197 197
Lines 14929 14929
=======================================
Hits 12843 12843
Misses 1776 1776
Partials 310 310 ☔ View full report in Codecov by Sentry. |
|
actually let me ask my question on the issue |
| # - ingress: istio-ambient | ||
| # namespace-resources: virtualservices | ||
| # ingress-class: istio | ||
| # ambient: 1 |
There was a problem hiding this comment.
linter warning on this file is legit - unsure why it can't detect the || and sorta ignore that the object is not defined (cc @kvmware)
There was a problem hiding this comment.
👍 I also uncommented the variable to make sure this works.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-1.12 |
|
@dprotaso: new pull request created: #14848 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Related to #14637
Proposed Changes
I'm proposing to disable the tests until they are more stable. Currently nearly every run needs a few retries until we can get the tests green.
/cc @nak3
/cc @dprotaso