Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable flaky ambient e2e tests #14638

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Disable flaky ambient e2e tests #14638

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86dff8c
Disable flaky ambient e2e tests
ReToCode Nov 20, 2023
bb8d60f
Fix lint error
ReToCode Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/kind-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,8 @@
- kourier-tls
- istio
- istio-tls
- istio-ambient
# Disabled due to flakiness: https://github.com/knative/serving/issues/14637
# - istio-ambient
- contour
# Disabled due to consistent failures
# - gateway_istio
Expand Down Expand Up @@ -124,10 +125,11 @@
namespace-resources: virtualservices
enable-tls: 1

- ingress: istio-ambient
namespace-resources: virtualservices
ingress-class: istio
ambient: 1
# Disabled due to flakiness: https://github.com/knative/serving/issues/14637
# - ingress: istio-ambient
# namespace-resources: virtualservices
# ingress-class: istio
# ambient: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linter warning on this file is legit - unsure why it can't detect the || and sorta ignore that the object is not defined (cc @kvmware)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I also uncommented the variable to make sure this works.


- ingress: kourier-tls
ingress-class: kourier
Expand All @@ -146,7 +148,7 @@
KIND: 1
INGRESS_CLASS: ${{ matrix.ingress-class || matrix.ingress }}.ingress.networking.knative.dev
ENABLE_TLS: ${{ matrix.enable-tls || 0 }}
AMBIENT: ${{ matrix.ambient || 0 }}

Check failure on line 151 in .github/workflows/kind-e2e.yaml

View workflow job for this annotation

GitHub Actions / style / suggester / github_actions 

[actionlint] reported by reviewdog 🐶
property "ambient" is not defined in object type {enable-tls: number; ingress: string; ingress-class: string; k8s-version: string; namespace-resources: string; test-path: string; test-suite: string} [expression]

Raw Output:
.github/workflows/kind-e2e.yaml:151:20: property "ambient" is not defined in object type {enable-tls: number; ingress: string; ingress-class: string; k8s-version: string; namespace-resources: string; test-path: string; test-suite: string} [expression]

steps:
- name: Set up Go 1.21.x
Expand Down
Loading