Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] attempt pod addressability for the autoscaler #15388

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dprotaso
Copy link
Member

Changes

  • change private K8s service to be a headless service
  • test passthrough with autoscaler

izabelacg and others added 2 commits July 10, 2024 14:32
* change private K8s service to be a headless service

* use clusteripnone constant
@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 10, 2024
Copy link

knative-prow bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2024
@knative-prow knative-prow bot requested review from ReToCode and skonto July 10, 2024 18:36
@dprotaso
Copy link
Member Author

/test all

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.56%. Comparing base (2156812) to head (190c73c).
Report is 107 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15388      +/-   ##
==========================================
- Coverage   84.58%   84.56%   -0.02%     
==========================================
  Files         219      219              
  Lines       13587    13587              
==========================================
- Hits        11492    11490       -2     
- Misses       1726     1728       +2     
  Partials      369      369              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member Author

/test all

@dprotaso
Copy link
Member Author

/test ?

Copy link

knative-prow bot commented Jul 10, 2024

@dprotaso: The following commands are available to trigger required jobs:

  • /test build-tests
  • /test contour-latest
  • /test contour-tls
  • /test gateway-api-latest
  • /test istio-latest-no-mesh
  • /test istio-latest-no-mesh-tls
  • /test kourier-stable
  • /test kourier-stable-tls
  • /test unit-tests
  • /test upgrade-tests

The following commands are available to trigger optional jobs:

  • /test gateway-api-latest-and-contour
  • /test https
  • /test istio-latest-mesh
  • /test istio-latest-mesh-short
  • /test istio-latest-mesh-tls
  • /test performance-tests

Use /test all to run the following jobs that were automatically triggered:

  • build-tests_serving_main
  • istio-latest-no-mesh-tls_serving_main
  • istio-latest-no-mesh_serving_main
  • unit-tests_serving_main
  • upgrade-tests_serving_main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Member Author

/test istio-latest-mesh
/test istio-latest-mesh-short
/test istio-latest-mesh-tls

Copy link

knative-prow bot commented Jul 10, 2024

@dprotaso: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
istio-latest-mesh-tls_serving_main 190c73c link false /test istio-latest-mesh-tls
istio-latest-mesh-short_serving_main 190c73c link false /test istio-latest-mesh-short
istio-latest-mesh_serving_main 190c73c link false /test istio-latest-mesh

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@skonto
Copy link
Contributor

skonto commented Jul 11, 2024

Failed to probe clusterIP None:80 err=error roundtripping http://None:80/healthz: dial tcp: lookup None on 10.26.112.10:53: no such host

@dprotaso
Copy link
Member Author

Yeah passthrough isn't enabled on the tests.

One thing though - I think we could do a headless service and do probing using the hostname instead of the cluster IP.

I'll do a separate PR for that

Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants