Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in cert manager config #15434

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Fix bug in cert manager config #15434

merged 2 commits into from
Aug 1, 2024

Conversation

mstein11
Copy link
Contributor

Fixes #15433

Release Note

Fixes Bug preventing the correct configuration of cert manager

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jul 31, 2024 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 31, 2024

Welcome @mstein11! It looks like this is your first PR to knative/serving 🎉

@knative-prow Knative Prow
Copy link

knative-prow bot commented Jul 31, 2024

Hi @mstein11. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2024
@mstein11 mstein11 changed the title Verify bug in cert manager config Fix bug in cert manager config Jul 31, 2024
@dprotaso
Copy link
Member

/ok-to-test
/assign @ReToCode @skonto

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 31, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.53%. Comparing base (5225d4f) to head (c446064).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #15434   +/-   ##
=======================================
  Coverage   84.53%   84.53%           
=======================================
  Files         219      219           
  Lines       13595    13595           
=======================================
  Hits        11492    11492           
+ Misses       1736     1735    -1     
- Partials      367      368    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

skonto
skonto reviewed Aug 1, 2024
View reviewed changes
pkg/reconciler/certificate/config/cert_manager.go
SystemInternalIssuerRef: knativeSelfSignedIssuer,
IssuerRef: knativeSelfSignedIssuer.DeepCopy(),
ClusterLocalIssuerRef: knativeSelfSignedIssuer.DeepCopy(),
SystemInternalIssuerRef: knativeSelfSignedIssuer.DeepCopy(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unmarshalling was affecting all pointers btw. So this returns a new pointer for each case with the same content.

@skonto
Copy link
Contributor

skonto commented Aug 1, 2024

/lgtm
/approve

cc @mgencur fyi

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Aug 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mstein11, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2024
@dprotaso
Copy link
Member

dprotaso commented Aug 1, 2024

/cherrypick release-1.15

@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.15 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit cac5e63 into knative:main Aug 1, 2024
68 checks passed
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #15437

In response to this:

/cherrypick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Aug 1, 2024
Merged
skonto pushed a commit to skonto/serving that referenced this pull request Aug 2, 2024
@mstein11 @skonto
Fix bug in cert manager config (knative#15434)
1ce800e 
* add test to cover cert manager config edge case

* fix edge case bug in cert manager config
openshift-merge-bot bot pushed a commit to openshift-knative/serving that referenced this pull request Aug 5, 2024
@skonto @mstein11
Fix bug in cert manager config (knative#15434) (#787)
3864b8f 
* add test to cover cert manager config edge case

* fix edge case bug in cert manager config

Co-authored-by: mstein11 <mariusstein7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skonto skonto skonto left review comments

@izabelacg izabelacg Awaiting requested review from izabelacg

@ReToCode ReToCode Awaiting requested review from ReToCode

Assignees

@skonto skonto

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
5 participants
@mstein11 @dprotaso @skonto @knative-prow-robot @ReToCode