Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E tests for startup probe #15461

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Aug 12, 2024

Additional tests for startup probes.

Proposed Changes

  • Verify startup probes can be used on sidecars.
  • Verify different types of startup probes can be used (TCPSocket, HTTPGet, GRPC)
  • Verify a liveness probe being aware of a startup probe. The liveness probe can only start after the startup probe succeeds.

Release Note


@knative-prow knative-prow bot requested review from ReToCode and skonto August 12, 2024 06:20
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 12, 2024
Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.46%. Comparing base (6554a7d) to head (78ca7fa).

Files Patch % Lines
pkg/testing/v1/service.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15461      +/-   ##
==========================================
- Coverage   84.48%   84.46%   -0.02%     
==========================================
  Files         219      219              
  Lines       13605    13608       +3     
==========================================
  Hits        11494    11494              
- Misses       1740     1743       +3     
  Partials      371      371              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Martin.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2024
Copy link

knative-prow bot commented Aug 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2024
@knative-prow knative-prow bot merged commit 64ac199 into knative:main Aug 12, 2024
68 checks passed
mgencur added a commit to mgencur/serving-1 that referenced this pull request Aug 12, 2024
* Add different types of startup probes to E2E test

* TestLivenessProbeAwareOfStartupProbe
openshift-merge-bot bot pushed a commit to openshift-knative/serving that referenced this pull request Aug 12, 2024
* Add different types of startup probes to E2E test

* TestLivenessProbeAwareOfStartupProbe
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/knative-serving that referenced this pull request Aug 12, 2024
* Add different types of startup probes to E2E test

* TestLivenessProbeAwareOfStartupProbe
openshift-merge-bot bot pushed a commit to openshift-knative/serving that referenced this pull request Aug 13, 2024
* Add different types of startup probes to E2E test

* TestLivenessProbeAwareOfStartupProbe

Co-authored-by: Martin Gencur <mgencur@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants