Don't scrape pods via HTTP if the activator in path #15539
Conversation
knative-prow
bot
added
needs-ok-to-test
|
Hi @yenniechen. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yenniechen The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| if pause { | ||
| continue | ||
| } | ||
|
|
There was a problem hiding this comment.
Currently, there's only coverage to pause, I assume based on TBC==-1. There's no logic to resume scrapping, correct?
| @@ -280,6 +280,8 @@ func (a *autoscaler) Scale(logger *zap.SugaredLogger, now time.Time) ScaleResult | |||
| case spec.TargetBurstCapacity > 0: | |||
| totCap := float64(originalReadyPodsCount) * spec.TotalValue | |||
| excessBCF = math.Floor(totCap - spec.TargetBurstCapacity - observedPanicValue) | |||
| case spec.TargetBurstCapacity == -1: | |||
| a.metricClient.Pause(metricKey) | |||
There was a problem hiding this comment.
What happens in cases that TBC is updated, after initially being -1?
|
/ok-to-test |
knative-prow
bot
added
ok-to-test
There was a problem hiding this comment.
@yenniechen thanks for the PR and contributions to Knative! I've posted a few questions aiming to better scope the intended changes. It seems to me like a partial fix to the original issue so far.
|
@yenniechen: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fixes #7324
Proposed Changes
*Start/Stop scraping if activator is in path or not. This is a little more tricky as we need to make sure that we start scraping timely once we notice the activator will be taken off the path.
*
Release Note