Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make XChange compatible with jakarta.ws.rs-api 3.x #4676

Closed
ppalaga opened this issue Feb 7, 2023 · 10 comments
Closed

Make XChange compatible with jakarta.ws.rs-api 3.x #4676

ppalaga opened this issue Feb 7, 2023 · 10 comments

Comments

@ppalaga
Copy link

ppalaga commented Feb 7, 2023

As far as I can see, the jakarta.ws.rs-api is pulled transitively via com.github.mmazi:rescu. Once a com.github.mmazi:rescu release compatible with jakarta.ws.rs-api 3.x is available, XChange should be adjusted as well. This is currently blocked by mmazi/rescu#142

It would be nice to have this to be able to use XChange on Quarkus 3.x.

@ppalaga
Copy link
Author

ppalaga commented Mar 1, 2023

mmazi/rescu#142 was fixed and com.github.mmazi:rescu 3.0 was released.

@martinformi
Copy link

I would be also quite interested in having this. It prevents me now to use Spring Boot 3.x. Unfortunately, how other projects are solving this is a bit not comfortable - having two libraries released, one with jakarta.* another one with javax.*, since it is breaking change.

@martinformi
Copy link

@ppalaga
Copy link
Author

ppalaga commented Mar 29, 2023

@ppalaga Peter, use this if needed - https://github.com/martinformi/XChange/tree/feature/jakarta-namespace

Great, would you mind sending a pull request against https://github.com/knowm/XChange ?

@martinformi
Copy link

martinformi commented Mar 29, 2023

I do not think the PR would be approved anytime soon, it is a breaking change that would break any usage in javax.* environments. That would mean having two different artifacts - xchange and xchange-jakarta. I will create PR and let's see.

Created PR - #4710.

@ppalaga
Copy link
Author

ppalaga commented Mar 29, 2023

Thanks for the PR. It is up to the project maintainers to decide how they deal with the incompatibility. I'd personally be fine with bumping the major version as having both xchange and xchange-jakarta dependencies in one project would not work anyway - it would not be possible to have transitives compatible with both of them.

@bigscoop
Copy link
Contributor

bigscoop commented Sep 4, 2023

@ppalaga looks like the MR #4735 resolves it. Feel free to test and eventually close the issue

@ppalaga
Copy link
Author

ppalaga commented Sep 4, 2023

Thanks for the heads up @bigscoop!

@jdlee726
Copy link

is already fixed?

@bigscoop
Copy link
Contributor

yes, issue can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants