Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Code cleanup #4705

Merged
merged 9 commits into from
Aug 13, 2023
Merged

[core] Code cleanup #4705

merged 9 commits into from
Aug 13, 2023

Conversation

bigscoop
Copy link
Contributor

  • Replaced boilerplate code with lombok
  • Replaced direct property access with getters

@bigscoop bigscoop marked this pull request as draft March 26, 2023 21:04
@walec51
Copy link
Collaborator

walec51 commented Jul 30, 2023

lombok has been added as a root dependency

please remove you chenges to pom.xml files and we can merge this PR

@bigscoop bigscoop marked this pull request as ready for review July 31, 2023 17:32
@bigscoop
Copy link
Contributor Author

lombok has been added as a root dependency

please remove you chenges to pom.xml files and we can merge this PR

@walec51 done

@walec51 walec51 merged commit 84cd9bc into knowm:develop Aug 13, 2023
1 check passed
@bigscoop bigscoop deleted the code-cleanup branch August 13, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants