Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Replace constructors in DefaultWithdrawFundsParams with according builders #4720

Closed
wants to merge 4 commits into from
Closed

[refactor] Replace constructors in DefaultWithdrawFundsParams with according builders #4720

wants to merge 4 commits into from

Conversation

bigscoop
Copy link
Contributor

  • Replaced constructors with according builders from lombok

@walec51
Copy link
Collaborator

walec51 commented Aug 13, 2023

merging this would break backward compatibility because you are removing a few constructors from the public API

@bigscoop
Copy link
Contributor Author

agree, I'll close it

@bigscoop bigscoop closed this Aug 13, 2023
@bigscoop bigscoop deleted the add-builder-to-DefaultWithdrawFundsParams-MR branch August 13, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bigscoop @walec51