Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to jakarta namespace #4735

Merged
merged 2 commits into from
Aug 13, 2023

Conversation

rvullriede
Copy link
Contributor

An updated version of #4710 base on the current develop branch. With the major frameworks (like Spring Boot 3.x) moving to jakarta I personally think there is no need for two builds (javax, jakarta) but simply a new major version XChange. Whoever needs the latest version can/must should move to jakarta.

@walec51
Copy link
Collaborator

walec51 commented Jul 30, 2023

look good, two questions:

  1. in the previous PR we had an explicit dependancy to jakarta.ws.rs-api
    in this PR is this library still being added trasitavly by mmazi ?

  2. does this in any way bump up the minimal java version one has to use?

@rvullriede
Copy link
Contributor Author

Hi,

thanks for looking into this!

  1. explicit declaration is not required since mmazi pulls the correct version already.
  2. No. It still compiles with source and target set to 1.8 and it should run fine on such a JVM.

@walec51 walec51 merged commit e63562d into knowm:develop Aug 13, 2023
2 checks passed
@rvullriede rvullriede deleted the feature/jakarta-namespace branch August 23, 2023 18:07
bigscoop added a commit to bigscoop/XChange that referenced this pull request Sep 5, 2024
bigscoop added a commit to bigscoop/XChange that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants