missing authorization headers issue fixed #725
Conversation
| const headers = JSON.parse(form.dataset.headers); | ||
| // Check for auth param that might go in header | ||
| if (form.dataset.authed === "1") { | ||
| const authHeaderEl = form.querySelector('input[data-component=header]'); | ||
| if (authHeaderEl) headers[authHeaderEl.name] = authHeaderEl.dataset.prefix + authHeaderEl.value; | ||
| } |
There was a problem hiding this comment.
I don't think this PR is right. Where does form.dataset.headers come from? There's no data-headers attribute on the form. And how do we know the auth header is the first item matching 'input[data-component=header]'?
There was a problem hiding this comment.
It comes from config
and output is like
<form id="form-POSTapi-login" data-method="POST"
data-path="api/login"
data-authed="0"
data-hasfiles="0"
data-isarraybody="0"
data-headers='{"Content-Type":"application\/json","Accept":"application\/json"}'
autocomplete="off"
onsubmit="event.preventDefault(); executeTryOut('POSTapi-login', this);">There was a problem hiding this comment.
and also this was in older version but removed in newer version don't know why...
There was a problem hiding this comment.
scribe/resources/js/tryitout.js
Line 230 in 028d606
There was a problem hiding this comment.
I've added missing data-headers='@JSON($endpoint->headers)' parameter
There was a problem hiding this comment.
Dude, you can't just add back something that was removed without trying to find out why. This is not good work. I'm sorry, I'll be closing this. You've made me waste time investigating this, only to find that you just copied an older version of these files. WTF. I suspect you're on an older version of Scribe and trying to change something in a newer version.
I'm closing this PR. If you wish to try again, please include a proper explanation of the issue you faced (with screenshots of before and after), and then explain how your fix actually changes things, not just copy/paste from an older version.
I was not able to test the try it out feature because of the headers... Few lines was missing in upgraded version...