Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET method query param set from request #742

Closed
wants to merge 1 commit into from

Conversation

sudippalash
Copy link

No description provided.

@shalvah
Copy link
Contributor

shalvah commented Oct 9, 2023

Please tell me what this is supposed to do, and include a before/after if you want me to merge it.

@sudip-fe
Copy link

Please tell me what this is supposed to do, and include a before/after if you want me to merge it.

Your package is awesome if developer is using DocBlocks in every function. But when developer not use DocBlocks before his function then your package generate from validation roles. It's also awesome but generate from validation roles only applicable for POST & PUT route. GET route query param not working for this scenario, That's why i am adding this code.

Check the below image:
image

@shalvah
Copy link
Contributor

shalvah commented Oct 10, 2023

Ah, I see. But that isn't the right solution. Check the docs for how to use validation rules for query parameters. https://scribe.knuckles.wtf/laravel/documenting/query-body-parameters#using-validation-rules-for-query-parameters

@shalvah shalvah closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants