Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow parse expressions with Request::validate facade usage #895

Conversation

geangontijo
Copy link
Contributor

@geangontijo geangontijo commented Sep 25, 2024

I have a project that use Facades to validate, then i think that this is useful.

Docs update:

@geangontijo
Copy link
Contributor Author

I run locally tests:

image

@shalvah
Copy link
Contributor

shalvah commented Oct 3, 2024

Thanks! Can you add a new test? You can see the example of Validator::make here?

@geangontijo
Copy link
Contributor Author

I have a observation about the tests that i maked:

I not replicate the GetFromInlineValidatorTest::respects_query_params_comment for Facade version because i think be a context from Knuckles\Scribe\Extracting\Strategies\BodyParameters\GetFromInlineValidator.

I your think this is a wrong interpretation of my part, i stay free to make changes

@shalvah shalvah merged commit 76a06e3 into knuckleswtf:master Oct 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants