Skip to content

Commit

Permalink
Nits
Browse files Browse the repository at this point in the history
  • Loading branch information
kohler committed Nov 7, 2024
1 parent b8137f2 commit 1e7d5ba
Showing 1 changed file with 8 additions and 9 deletions.
17 changes: 8 additions & 9 deletions src/contact.php
Original file line number Diff line number Diff line change
Expand Up @@ -3773,20 +3773,19 @@ function can_view_manager(?PaperInfo $prow = null) {
}

/** @return bool */
function can_view_lead(?PaperInfo $prow = null) {
if ($prow) {
$rights = $this->rights($prow);
return $rights->can_administer()
|| $prow->leadContactId === $this->contactXid
|| (($rights->allow_pc() || $rights->is_reviewer())
&& $this->can_view_review_identity($prow, null));
} else {
function can_view_lead(?PaperInfo $prow) {
if (!$prow) {
return $this->isPC;
}
$rights = $this->rights($prow);
return $rights->can_administer()
|| $prow->leadContactId === $this->contactXid
|| (($rights->allow_pc() || $rights->is_reviewer())
&& $this->can_view_review_identity($prow, null));
}

/** @return bool */
function can_view_shepherd(?PaperInfo $prow = null) {
function can_view_shepherd(?PaperInfo $prow) {
// XXX Allow shepherd view when outcome == 0 && can_view_decision.
// This is a mediocre choice, but people like to reuse the shepherd field
// for other purposes, and I might hear complaints.
Expand Down

0 comments on commit 1e7d5ba

Please sign in to comment.