feat: supports php 5.6

kokororin · Sep 5, 2023 · 394d452 · 394d452
1 parent bc9a69a
commit 394d452
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -8,7 +8,7 @@ jobs:
     strategy:
       matrix:
         os: [macos-latest, windows-latest]
-        php-version: ['7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3']
+        php-version: ['5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3']
     name: Test on ${{ matrix.os }} & PHP ${{ matrix.php-version }}
     steps:
       - name: Checkout

diff --git a/README.md b/README.md
@@ -9,7 +9,7 @@ The missing phpfmt extension for Visual Studio Code.
 
 Open command palette `F1` and select `Extensions: Install Extension`, then search for phpfmt.
 
-**Note**: PHP 7.x or newer is required in the machine to run this plugin.
+**Note**: PHP 5.6 or newer is required in the machine to run this plugin.
 
 
 ## Usage

diff --git a/src/PHPFmt.ts b/src/PHPFmt.ts
@@ -217,8 +217,8 @@ export class PHPFmt {
           throw new PHPFmtError('PHP version < 5.6 or > 8.0');
         }
       } else {
-        if (semver.lt(phpVersion, '7.0.0')) {
-          throw new PHPFmtError('PHP version < 7 is not supported');
+        if (semver.lt(phpVersion, '5.6.0') || semver.gt(phpVersion, '8.3.0')) {
+          throw new PHPFmtError('PHP version < 5.6 or > 8.3');
         }
       }
     } catch (err) {